Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo-shuttle): beta updated local run #1850

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Aug 1, 2024

extends #1844

tested local run with:
rocket/hello-world
rocket/postgres
rocket/secrets

@jonaro00 jonaro00 marked this pull request as ready for review August 2, 2024 10:05
@jonaro00 jonaro00 changed the title wip: beta updated local run feat(cargo-shuttle): beta updated local run Aug 2, 2024
Comment on lines -1419 to -1421
// Set beta to false to avoid breaking local run with beta changes.
// TODO: make local run compatible with --beta.
false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the comment no longer accurate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating resource tables (if we want tables at all) for beta is still TODO, so whatever happens here will change.

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
@jonaro00 jonaro00 merged commit 25f8a75 into shuttle-hq:main Aug 2, 2024
24 of 25 checks passed
@jonaro00 jonaro00 deleted the beta-local-run branch August 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants