Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable honeycomb export, remove vars #1868

Merged
merged 1 commit into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,6 @@ jobs:
mongodb-password:
description: "Shuttle shared mongodb password"
type: env_var_name
honeycomb-api-key:
description: "Shuttle honeycomb api key for observability based on environment"
type: env_var_name
deploys-api-key:
description: "Shuttle api key used by the gateway to authorise starting idle deployments"
type: env_var_name
Expand Down Expand Up @@ -382,7 +379,6 @@ jobs:
MONGO_INITDB_ROOT_PASSWORD=${<< parameters.mongodb-password >>} \
DD_API_KEY=$DD_API_KEY \
DD_ENV=<< parameters.shuttle-env >> \
HONEYCOMB_API_KEY=${<< parameters.honeycomb-api-key >>} \
DEPLOYS_API_KEY=${<< parameters.deploys-api-key >>} \
LOGGER_POSTGRES_URI=${<< parameters.logger-postgres-uri >>} \
STRIPE_SECRET_KEY=${<< parameters.stripe-secret-key >>} \
Expand Down Expand Up @@ -658,7 +654,6 @@ workflows:
name: Deploy images to unstable
postgres-password: DEV_POSTGRES_PASSWORD
mongodb-password: DEV_MONGO_INITDB_ROOT_PASSWORD
honeycomb-api-key: DEV_HONEYCOMB_API_KEY
deploys-api-key: DEV_DEPLOYS_API_KEY
logger-postgres-uri: DEV_LOGGER_POSTGRES_URI
stripe-secret-key: DEV_STRIPE_SECRET_KEY
Expand Down Expand Up @@ -729,7 +724,6 @@ workflows:
name: deploy-images-to-production
postgres-password: PROD_POSTGRES_PASSWORD
mongodb-password: PROD_MONGO_INITDB_ROOT_PASSWORD
honeycomb-api-key: PROD_HONEYCOMB_API_KEY
deploys-api-key: PROD_DEPLOYS_API_KEY
logger-postgres-uri: PROD_LOGGER_POSTGRES_URI
stripe-secret-key: PROD_STRIPE_SECRET_KEY
Expand Down
2 changes: 0 additions & 2 deletions DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ make up

> Note: `make up` can also be run with `SHUTTLE_DETACH=disable`, which means docker-compose will not be run with `--detach`. This is often desirable for local testing.
>
> Note: `make up` can also be run with `HONEYCOMB_API_KEY=<api_key>` if you have a honeycomb.io account and want to test the instrumentation of the services. This is mostly used only by the internal team.
>
> Note: Other useful commands can be found within the [Makefile](./Makefile).

The API is now accessible on `localhost:8000` (for app proxies) and `localhost:8001` (for the control plane). When running `cargo run -p cargo-shuttle` (in a debug build), the CLI will point itself to `localhost` for its API calls.
Expand Down
1 change: 0 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@ services:
- SHUTTLE_ENV=${SHUTTLE_ENV}
- DD_API_KEY=${DD_API_KEY}
- DD_ENV=${DD_ENV}
- HONEYCOMB_API_KEY=${HONEYCOMB_API_KEY}
deploy:
placement:
constraints:
Expand Down
4 changes: 0 additions & 4 deletions extras/otel/otel-collector-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,6 @@ exporters:
span_name_as_resource_name: true
trace_buffer: 25
# peer_tags_aggregation: true
otlp:
endpoint: "api.honeycomb.io:443"
headers:
"x-honeycomb-team": ${env:HONEYCOMB_API_KEY}
service:
pipelines:
traces:
Expand Down
2 changes: 0 additions & 2 deletions logger/src/dal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ impl Postgres {
if rx.len() >= 200 {
warn!(
queue_size = rx.len(),
// This string is matched in a honeycomb trigger, changing it will
// break the trigger.
"database receiver queue is filling up"
);
} else if !rx.is_empty() {
Expand Down