feat(cargo-shuttle): v0.48.2, colored platform outputs, fixes #1886

jonaro00 · 2024-09-30T10:42:40Z

No description provided.

greptile-apps

PR Summary

This pull request introduces colored platform outputs and refines the CLI interface for the cargo-shuttle command-line tool. Key changes include:

Added color-coded platform information in lib.rs for improved user experience
Updated command descriptions and visibilities in args.rs to prepare features for wider use
Removed 'BETA' labels from several commands, indicating stability
Adjusted the 'Deploy' command to use 'WIP' instead of 'BETA' for Docker image deployment

_{2 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-10-07T15:57:47Z

cargo-shuttle/src/lib.rs

+        if self.beta {
+            eprintln!("{}", "INFO: Using NEW platform API (shuttle.dev)".green());
+        } else {
+            eprintln!("{}", "INFO: Using OLD platform API (shuttle.rs)".blue());


style: Consider using a constant for the color strings (e.g., 'green' and 'blue') to improve maintainability

greptile-apps

PR Summary

(updates since last review)

Based on the provided information and the previous review, here's a concise summary of the additional changes and potential areas of focus for this pull request:

Updated project configuration structure in config.rs:
- Deprecated the assets field
- Introduced new deploy and build configurations
- Updated the include method to handle both new and deprecated asset configurations
Minor version bump in Cargo.toml:
- Updated cargo-shuttle version from 0.48.0 to 0.48.1
Refined error handling in lib.rs:
- Improved error messages related to platform-specific commands

These changes aim to enhance the deployment and build processes, providing more granular control over file inclusion and asset management. The review should focus on the implementation of the new configuration structure and its potential impact on existing projects.

_{4 file(s) reviewed, 3 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-10-07T16:00:25Z

cargo-shuttle/src/lib.rs

+        if self.beta {
+            eprintln!("{}", "INFO: Using NEW platform API (shuttle.dev)".green());
+        } else {
+            eprintln!("{}", "INFO: Using OLD platform API (shuttle.rs)".blue());


style: Consider using constants for the color strings (e.g., 'green' and 'blue') to improve maintainability

greptile-apps · 2024-10-07T16:00:27Z

cargo-shuttle/src/lib.rs

+                eprintln!(
+                    "{}",
+                    format!("INFO: Targeting non-default API: {url}").yellow(),
+                );


style: Use a constant for the 'INFO:' prefix to ensure consistency across messages

greptile-apps · 2024-10-07T16:00:28Z

cargo-shuttle/src/lib.rs

@@ -1118,7 +1124,7 @@ impl Shuttle {

    async fn logs_beta(&self, args: LogsArgs) -> Result<()> {
        if args.follow {
-            eprintln!("Streamed logs are not yet supported on beta.");
+            eprintln!("Streamed logs are not yet supported on the new platform.");


style: Update error message to use 'NEW platform' for consistency with other messages

greptile-apps

PR Summary

(updates since last review)

This PR introduces colored output for platform-related messages in the cargo-shuttle CLI and updates API key handling. Here's a concise summary of the key changes:

Added colored output in cargo-shuttle/src/lib.rs for better visual distinction between platform versions and messages
Simplified API key handling in cargo-shuttle/src/config.rs by removing the ApiKey type
Introduced SHUTTLE_LOGIN_URL_BETA constant in common/src/constants.rs for beta platform support

These changes aim to improve user experience and prepare for beta platform support. The review should focus on the implementation of these features and their impact on usability.

_{3 file(s) reviewed, 3 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-10-08T11:34:29Z

cargo-shuttle/src/lib.rs

+        if self.beta {
+            eprintln!("{}", "INFO: Using NEW platform API (shuttle.dev)".green());
+        } else {
+            eprintln!("{}", "INFO: Using OLD platform API (shuttle.rs)".blue());


style: Use constants for the color strings (e.g., 'green' and 'blue') to improve maintainability

greptile-apps · 2024-10-08T11:34:29Z

cargo-shuttle/src/lib.rs

+                eprintln!(
+                    "{}",
+                    format!("INFO: Targeting non-default API: {url}").yellow(),
+                );


style: Use a constant for the 'INFO:' prefix to ensure consistency across messages

greptile-apps · 2024-10-08T11:34:31Z

cargo-shuttle/src/lib.rs

@@ -1118,7 +1124,7 @@ impl Shuttle {

    async fn logs_beta(&self, args: LogsArgs) -> Result<()> {
        if args.follow {
-            eprintln!("Streamed logs are not yet supported on beta.");
+            eprintln!("Streamed logs are not yet supported on the new platform.");


style: Update error message to use 'NEW platform' for consistency with other messages

greptile-apps

PR Summary

(updates since last review)

This PR introduces significant changes to the Shuttle CLI, focusing on simplifying the command structure and improving user experience. Here's a concise summary of the key updates:

Changed CLI command structure from 'cargo shuttle' to 'shuttle' across multiple files
Simplified deployment process by removing the separate project creation step
Updated documentation and error messages to reflect new command structure
Introduced colored output for platform-specific messages in cargo-shuttle/src/lib.rs

These changes aim to streamline the user experience and prepare for the new beta platform. The implementation appears consistent across various files, including documentation and error messages.

_{12 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This pull request makes a minor version update to the cargo-shuttle package, incrementing it from version 0.48.1 to 0.48.2. Here's a concise summary of the key changes:

Updated cargo-shuttle version to 0.48.2 in cargo-shuttle/Cargo.toml
Introduced colored output for platform-specific messages in the CLI

This update likely includes small improvements or bug fixes to enhance the user experience with the Shuttle CLI tool.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This pull request makes minor improvements to the cargo-shuttle CLI tool, focusing on enhancing user experience and clarity. Here's a concise summary of the key changes:

Updated project deletion confirmation message in cargo-shuttle/src/lib.rs:
- Now uses project ID instead of project name for more precise identification
- Improves clarity in the warning message for users

The changes are minimal but contribute to a better user experience when managing projects through the Shuttle CLI.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This pull request introduces a small but important change to the runtime/src/start.rs file, enhancing the user experience for the Shuttle CLI tool. Here's a concise summary of the key modification:

Conditional logging in runtime/src/start.rs:
- Provides different documentation URLs based on the beta argument
- Directs users to the appropriate documentation for their platform (beta or non-beta)

This change improves user guidance by ensuring they are referred to the correct documentation resources, tailored to their specific platform environment.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

jonaro00 force-pushed the beta-final-fixes branch from 4dd0d03 to 5bfacd3 Compare September 30, 2024 10:46

jonaro00 changed the title ~~fix(cargo-shuttle): beta fixes~~ feat(cargo-shuttle): colored platform outputs Oct 2, 2024

jonaro00 force-pushed the beta-final-fixes branch 2 times, most recently from 643f683 to f35ce48 Compare October 3, 2024 13:13

jonaro00 added 4 commits October 7, 2024 17:56

feat: colored platform outputs

c4bcad9

chore: unhide beta commands

93e4790

nits

b4d12c8

fix: beta deprecate clean command

70f0912

jonaro00 force-pushed the beta-final-fixes branch from 568fa5f to 70f0912 Compare October 7, 2024 15:56

greptile-apps bot reviewed Oct 7, 2024

View reviewed changes

fix(cargo-shuttle): don't validate api key, beta login url

c1dd737

greptile-apps bot reviewed Oct 8, 2024

View reviewed changes

fix: mentions of cargo shuttle

7124143

greptile-apps bot reviewed Oct 8, 2024

View reviewed changes

chore: bump cargo-shuttle

f7dd3ef

greptile-apps bot reviewed Oct 9, 2024

View reviewed changes

jonaro00 changed the title ~~feat(cargo-shuttle): colored platform outputs~~ feat(cargo-shuttle): colored platform outputs + fixes Oct 9, 2024

fix: show project id when deleting

81f54f6

greptile-apps bot reviewed Oct 9, 2024

View reviewed changes

jonaro00 changed the title ~~feat(cargo-shuttle): colored platform outputs + fixes~~ feat(cargo-shuttle): v0.48.2, colored platform outputs, fixes Oct 9, 2024

tracing log

d910c2b

greptile-apps bot reviewed Oct 10, 2024

View reviewed changes

jonaro00 merged commit be7b731 into main Oct 10, 2024
31 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cargo-shuttle): v0.48.2, colored platform outputs, fixes #1886

feat(cargo-shuttle): v0.48.2, colored platform outputs, fixes #1886

jonaro00 commented Sep 30, 2024

greptile-apps bot left a comment

greptile-apps bot Oct 7, 2024

greptile-apps bot left a comment

greptile-apps bot Oct 7, 2024

greptile-apps bot Oct 7, 2024

greptile-apps bot Oct 7, 2024

greptile-apps bot left a comment

greptile-apps bot Oct 8, 2024

greptile-apps bot Oct 8, 2024

greptile-apps bot Oct 8, 2024

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

feat(cargo-shuttle): v0.48.2, colored platform outputs, fixes #1886

feat(cargo-shuttle): v0.48.2, colored platform outputs, fixes #1886

Conversation

jonaro00 commented Sep 30, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Oct 7, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Oct 7, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 7, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 7, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Oct 8, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 8, 2024

Choose a reason for hiding this comment

greptile-apps bot Oct 8, 2024

Choose a reason for hiding this comment

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary