-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: plugins #273
refactor: plugins #273
Conversation
7f21081
to
8417699
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holy conflict mackerel! I hope I resolved this without creating more issues (apart from the ones outlined below, due to the time difference between when this was introduced and support for additional resources we have added since then).
Couple more things not specifically pointed at in the comments below:
- Web frameworks do not seem to have been modularised at all?
- The CLI is missing a small tweak for secrets I think
- Serenity is not modularised either (due to time difference)
- The modules don't seem to call on their dependencies through fully qualified versions, so I guess this will need to be added before publishing
- On that topic, will the publish scripts handle the version strings in the new crates correctly?
e008f44
to
cb496f0
Compare
1c2d2db
to
04efd40
Compare
04efd40
to
73ea16f
Compare
This turns our service feature flags into separate crates. The long game here will be to allow vendors to write their own plugins...
TODO
Breaking changes
This changes the main function argument attributes yet again 😃 . These changes are as follow:
The old feature flag on
shuttle_service
also needs to be replaced with the following crates definitions: