-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serenity integration #303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
force-pushed
the
feat/serenity-integration
branch
from
August 24, 2022 12:27
e4bba55
to
46bff1e
Compare
Looks great so far! Would also be good if we could get |
oddgrd
force-pushed
the
feat/serenity-integration
branch
from
August 24, 2022 19:32
634c1c8
to
67aedb1
Compare
chesedo
reviewed
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is exciting @oddgrd!! Just some minor questions 😃
chesedo
reviewed
Aug 26, 2022
chesedo
reviewed
Aug 26, 2022
- implement Service for serenity::Client to deploy discord bots with shuttle - add hello-world and postgres examples
- replace println's with tracing macros for logging - add readme for setting up and inviting bot in hello-world example
- replace tracing macros with log macros - write readme for postgres example
- update cargo.lock
oddgrd
force-pushed
the
feat/serenity-integration
branch
from
August 29, 2022 11:05
e5c7981
to
f29b7a7
Compare
chesedo
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
Service
forserenity::Client
. This enable Discord bot-developers using Serenity to easily deploy bots with with or without databases. I've added two usage examples, a basichello-world
bot and atodo-list
bot withshared::Postgres
for persistence.The integration works in it's current state with a valid token, but is a WIP as I am trying to figure out how to write tests for it. It's not straight-forward as the bot listens for commands via web-socket from Discord's servers. A valid discord token is also needed for the bot client to start.Closes #281