Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Persistant Storage #306

Merged
merged 22 commits into from
Sep 21, 2022
Merged

Feat: Persistant Storage #306

merged 22 commits into from
Sep 21, 2022

Conversation

Butch78
Copy link
Contributor

@Butch78 Butch78 commented Aug 16, 2022

No description provided.

@Butch78
Copy link
Contributor Author

Butch78 commented Aug 16, 2022

I will probably need to improve the error handling and I will create a simple example for Persist using Rocket

@Butch78 Butch78 marked this pull request as ready for review August 18, 2022 11:51
chesedo
chesedo reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a lot of comments, likely there are quite a few formatting related ones 😅

All in all, thanks for this! It seems about done

examples/rocket/persist/Cargo.toml Outdated Show resolved Hide resolved
examples/rocket/persist/src/lib.rs Outdated Show resolved Hide resolved
examples/rocket/persist/src/lib.rs Outdated Show resolved Hide resolved
examples/rocket/persist/src/lib.rs Show resolved Hide resolved
examples/rocket/persist/src/lib.rs Outdated Show resolved Hide resolved
service/src/persist.rs Outdated Show resolved Hide resolved
service/src/persist.rs Outdated Show resolved Hide resolved
service/src/persist.rs Outdated Show resolved Hide resolved
service/Cargo.toml Outdated Show resolved Hide resolved
service/Cargo.toml Outdated Show resolved Hide resolved
@Butch78 Butch78 requested a review from chesedo September 6, 2022 20:45
@chesedo chesedo merged commit dbfb0ee into shuttle-hq:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Butch78 @chesedo