Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: init rocket dependency version #314

Merged
merged 5 commits into from
Aug 25, 2022
Merged

fix: init rocket dependency version #314

merged 5 commits into from
Aug 25, 2022

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Aug 23, 2022

fixes #313, which needed the prerelease version of rocket.

Thanks for the tip @chesedo, and for spotting the issue @Butch78 😄

@coszio
fix: rocket dependency version
acf8bd6 
fixes shuttle-hq#313, which needed the prerelease version of `rocket`
chesedo
chesedo suggested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy PR @coszio!

cargo-shuttle/src/init.rs Outdated Show resolved Hide resolved
coszio
coszio commented Aug 24, 2022
View reviewed changes
cargo-shuttle/src/init.rs Outdated Show resolved Hide resolved
@coszio coszio requested a review from chesedo August 24, 2022 21:43
chesedo
chesedo approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @coszio!

cargo-shuttle/src/init.rs Outdated Show resolved Hide resolved
@chesedo chesedo merged commit af4420a into shuttle-hq:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo shuttle init --rocket --hello-world
2 participants
@coszio @chesedo