fix: update meta DB state even on factory failure #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick workaround for #197.
In a nutshell: secrets are implemented through a separate API endpoint that sets them directly in the DB backend that is attached to a deployment (this is actually pretty unsafe, this should be fixed). However, a DB is attached to a deployment's state only after a successful load and not at all if the factory phase of deployment fails. This leads to a situation where the DB is provisioned but that is not reflected in the deployment's state. And in that case, the secrets endpoints on the API silently fail.
Since a much better approach is on the way in
feat/deployer, this simple fix will do for now. A client-side update is on the way as well.