Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added field in Cargo.toml to avoid accidental publishing #358

Merged
merged 1 commit into from
Oct 17, 2022
Merged

feat: added field in Cargo.toml to avoid accidental publishing #358

merged 1 commit into from
Oct 17, 2022

Conversation

christos-h
Copy link
Member

Closes #352.

chesedo
chesedo approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @christoshadjiaslanis

@chesedo
Copy link
Contributor

chesedo commented Sep 29, 2022

@christoshadjiaslanis I was expecting some test to fail with this update 😕 Since none is failing it means we are missing a test case. Would you be able to add a unit test for cargo_shuttle_init()?

@chesedo chesedo merged commit 2d67c6b into main Oct 17, 2022
@chesedo chesedo deleted the feat/no-publish-cargo-toml branch October 17, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shutte init : add publish: false in cargo.toml
2 participants
@christos-h @chesedo