Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify tokio version in shuttle_service #476

Closed
wants to merge 1 commit into from

Conversation

snylonue
Copy link

It will prevent other packages depending on a newer version of tokio from building.

@oddgrd
Copy link
Contributor

oddgrd commented Nov 11, 2022

Hey @snylonue, welcome and thanks for the PR! Unfortunately we have to lock down the tokio version currently, which does mean certain dependencies won't work with shuttle. Until we can fix this issue, you may be able to use an older version of the incompatible crate.

Context: #348

@chesedo
Copy link
Contributor

chesedo commented Nov 14, 2022

Thanks for this @snylonue!! As Oddbjorn said, our current architecture needs to have the version pinned. However, this should be something we'll be able to get rid of in the future as we're improving our isolation model.

But still, thanks a lot for contributing to shuttle!!

@chesedo chesedo closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants