Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: local uri #596

Merged
merged 5 commits into from
Jan 26, 2023
Merged

feat: local uri #596

merged 5 commits into from
Jan 26, 2023

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Jan 25, 2023 •
edited
Loading

Also need this for:

  • RDS
  • Shared mongo

@chesedo chesedo force-pushed the feature/eng-393-overriding-resources branch from fcf9e57 to 4045966 Compare January 25, 2023 14:26
@chesedo chesedo marked this pull request as ready for review January 26, 2023 06:54
oddgrd
oddgrd approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Just a tiny typo nit. 😄

resources/aws-rds/README.md Outdated Show resolved Hide resolved
@chesedo @oddgrd
Update resources/aws-rds/README.md
21b7a44 
Co-authored-by: Oddbjørn Grødem <29732646+oddgrd@users.noreply.github.com>
@chesedo chesedo merged commit bd57774 into shuttle-hq:main Jan 26, 2023
@chesedo chesedo deleted the feature/eng-393-overriding-resources branch January 26, 2023 08:35
@chesedo chesedo mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesedo @oddgrd