fix: add repo url to cargo-shuttle for binstall #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-binstallneeds the crate to have a repository set in its manifest for it to find the binary download. We should only need to set it forcargo-shuttle, but it's nice to have for all our published crates.There was also an issue with the windows bin build where the tag was not included in the archive name, due to that build running the
make-artifactcommand with powershell. I resolved this by changing the shell for the windows build to bash, and using a powershell override for the other commands.I also changed the name of the directory inside the archive to be compatible with
cargo-binstall.And last but not least, I added the
x86_64-unknown-linux-gnutarget to the linux binary builds.