Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release flag #611

Merged
merged 12 commits into from
Feb 8, 2023
Merged

Release flag #611

merged 12 commits into from
Feb 8, 2023

Conversation

gautamprikshit1
Copy link
Contributor

Fixes #609

@oddgrd
Copy link
Contributor

oddgrd commented Feb 6, 2023

This looks good @gautamprikshit1, but do you think you could clean up those extra commits? Generally when you start a new PR, you should make sure main is updated, then you create your new branch from the updated main branch. Here it looks like you started a new PR from a previous PR branch.

Another small thing, you should try to make commit messages descriptive, rather than using the same message for all commits on a PR. You don't have to follow this exactly, but here are some example guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oddgrd oddgrd merged commit 92ddf6e into shuttle-hq:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add -r / --release flag to cargo-shuttle run
2 participants