feat: retry on bollard errors #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker would sometimes crash that it could not parse the network id. Since we don't need the network id to attach to the user network we can safely stop it into the network options. This allows removing quite a bit of auxilary code.
chesedo
force-pushed
the
feature/eng-421-retry-on-bollard-errors
branch
from
87e02c4 to
c3f3043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds three new project states to improve the stability of project creation:
Recreatingto recreate a container from scratch that failed to connect to the networkRestartingto try to start a container that failed to startRebootingto reboot container that became unhealthyThis causes the
Stoppedstate to become a sink / dead end.Things still to do: