Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for install docker buildx issue #29 #636

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Fix for install docker buildx issue #29 #636

merged 3 commits into from
Feb 17, 2023

Conversation

sentinel1909
Copy link
Contributor

@sentinel1909 sentinel1909 commented Feb 16, 2023

Good morning,

I took a stab at a fix for the "docker-buildx" related issue shuttle-hq/shuttle-docs#29 in the open issues noted in the docs repo.

Just trying to get comfy with this process by helping with simple issues. :)

Thanks,

~Jeff Mitchell

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this @sentinel1909!

I wonder if it might be worth having this as a separate note? Ie have a "> Note Windows:" line and a "> Note Linux:" line 🤷‍♂️

@sentinel1909
Copy link
Contributor Author

sentinel1909 commented Feb 17, 2023

Nice, thanks for this @sentinel1909!

I wonder if it might be worth having this as a separate note? Ie have a "> Note Windows:" line and a "> Note Linux:" line 🤷‍♂️

That thought floated through my mind to...probably would be more clear. Have done it... :)

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff!

@oddgrd oddgrd merged commit 392021e into shuttle-hq:main Feb 17, 2023
@sentinel1909 sentinel1909 deleted the docker-buildx-note branch April 6, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants