Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auth] refactor: update gateway deployer and provisioner #642

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Feb 20, 2023

No description provided.

@chesedo chesedo force-pushed the feature/eng-441-update-gateway-deployer-and-provisioner branch from 3525725 to b073baa Compare February 20, 2023 08:41
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Pieter! 🥳 I left a few comments, but nothing major.

common/src/backends/auth.rs Show resolved Hide resolved
common/src/backends/auth.rs Outdated Show resolved Hide resolved
common/src/backends/auth.rs Outdated Show resolved Hide resolved
deployer/src/handlers/mod.rs Show resolved Hide resolved
@chesedo chesedo marked this pull request as ready for review February 22, 2023 07:03
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, just one comment/question for the future, but not blocking.

@chesedo chesedo merged commit e8536e8 into shuttle-hq:main Feb 22, 2023
@chesedo chesedo deleted the feature/eng-441-update-gateway-deployer-and-provisioner branch February 22, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants