feat: auth cache #643
Merged
feat: auth cache #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently called directly in `convert_key`, should be a generic layer usable by other handlers as well
oddgrd
force-pushed
the
feature/eng-439-cache-layer
branch
2 times, most recently
from
84d12a9 to
5dc8f0a
Compare
chesedo
reviewed
Feb 22, 2023
also comment out broken test and add TODO to it, and revert auth manifest changes
oddgrd
force-pushed
the
feature/eng-439-cache-layer
branch
from
2361fd1 to
a6265c2
Compare
oddgrd
commented
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache in front of the reverse proxy in the
ShuttleAuthLayerthat tries to upgrade a cookie or api-key bearer token to a JWT. The cache is first checked for the key (cookie or api-key), if it is there set it on the request in theShuttleAuthLayer. If it isn't, request an upgrade from theauthserver through the proxy. If it succeeds, extract the token from the proxy response and set it in the cache, before setting it on the request and proceeding.It would have been more elegant to have the cache be a layer on the proxy client, but I had some difficulty implementing this. It's certainly something we should consider in the future.
All tests pass except for one assertion in the
api_create_get_delete_projectstest, which is commented out. It was indeed broken, but it was testing functionality we don't have.