Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OpenTelemetry collector #649

Merged
merged 2 commits into from
Feb 24, 2023
Merged

feat: OpenTelemetry collector #649

merged 2 commits into from
Feb 24, 2023

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Feb 24, 2023

No description provided.

oddgrd
oddgrd approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to read up on this a bit more, but LGTM currently. Thanks Pieter!

Ps. the CI is fixed on main now.

@chesedo chesedo merged commit f8d5ac8 into shuttle-hq:main Feb 24, 2023
@chesedo chesedo deleted the feature/eng-456-create-collector-container branch February 24, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chesedo @oddgrd