Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove target from bin build name #650

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Feb 24, 2023

Remove the target from the binary name to be compatible with binstall, and also switch to using only the short-form git tag.

See first commit's workflow run for successful run, and see the new draft release in releases for a preview of the binaries.

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddgrd oddgrd merged commit f45c6ca into main Feb 24, 2023
@oddgrd oddgrd deleted the fix/remove-target-from-bin-build-name branch February 24, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants