Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove time v0.1 dependency from main crates #664

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Remove time v0.1 dependency from main crates #664

merged 1 commit into from
Mar 2, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Mar 1, 2023

  • Mongodb v2.4.0 got rid of its time v0.1 dependency. This plus removing default features on chrono results in all of shuttle's main crates not depending on it (by default, shuttle-service with thruster still does due to thruster's direct dependency on it).
  • Removed Cargo.lock from .gitignore since it is being tracked by git.

chesedo
chesedo approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this @jonaro00

oddgrd
oddgrd approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonaro00! This is good to go, but we may need to update the mongodb example too then? We can do it before the next release, but if you'd like to do it that would be great 🙂

@oddgrd oddgrd merged commit 93d2b8d into shuttle-hq:main Mar 2, 2023
@jonaro00 jonaro00 mentioned this pull request Mar 4, 2023
Closed
@jonaro00 jonaro00 deleted the fix/timev0.1 branch March 23, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonaro00 @chesedo @oddgrd