Reference container images by full name #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierendavies
force-pushed
the
chore/container-full-names
branch
from
61e6d22 to
118942b
Compare
chesedo
approved these changes
Mar 17, 2023
|
I don't see a merge button, presumably because of the timeouts in the |
This is useful for users of Podman, which isn't configured out-of-the-box to use the `docker.io` registry. It's also a good security practice, in case of a misconfigured default registry.
kierendavies
force-pushed
the
chore/container-full-names
branch
from
118942b to
3eb2996
Compare
|
I missed some hard-coded image names. Branch updated. (And also rebased onto latest |
Oh, I was just waiting to get the latest release out before merging all these. Should happen sometime today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for users of Podman, which isn't configured out-of-the-box to use the
docker.ioregistry. It's also a good security practice, in case of a misconfigured default registry.