Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo.lock: remove patch unused occurrences #742

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

iulianbarbu
Copy link
Contributor

@iulianbarbu iulianbarbu commented Mar 22, 2023

Introduced previously in a PR and this doesn't need to live in the repo.

@iulianbarbu iulianbarbu force-pushed the fix/cargo-lock branch 2 times, most recently from e8c4e50 to 0b9fb31 Compare March 22, 2023 11:42
@iulianbarbu iulianbarbu requested review from chesedo and oddgrd March 22, 2023 11:51
@iulianbarbu iulianbarbu self-assigned this Mar 22, 2023
...is shipped already with patched dependencies.
Introduced previously in a PR.
@iulianbarbu iulianbarbu force-pushed the fix/cargo-lock branch 2 times, most recently from bb42cc2 to 6e15096 Compare March 22, 2023 12:06
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Iulian! Just one thought, perhaps this should be a step in the workspace job instead?

@iulianbarbu
Copy link
Contributor Author

LGTM, thanks Iulian! Just one thought, perhaps this should be a step in the workspace job instead?

I think it makes sense to move it to the workspace job. I am testing it rn.

@iulianbarbu iulianbarbu merged commit a31db06 into shuttle-hq:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants