tests: make provisioner test deterministic #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Mar 30, 2023
Comment on lines
+54
to
+57
| // Mongo starts up twice. So wait for the first one to finish | ||
| sleep(Duration::from_millis(350)); | ||
| Self::wait_ready(Duration::from_secs(120), &is_ready_cmd); | ||
|
|
There was a problem hiding this comment.
If it only starts twice for mongo, should check the db type before this second wait?
There was a problem hiding this comment.
Yes, we can. For both DBs this will only run once for all the tests. So I'm not sure if the extra complexity (if statement) is worth it 🤷♂️
oddgrd
pushed a commit
to oddgrd/shuttle
that referenced
this pull request
Mar 31, 2023
* tests: make test deterministic * tests: make test deterministic 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When the mongo tests ran, the server would restart as part of its startup process. So just give it some time to start up correctly.
How Has This Been Tested (if applicable)?
By running the tests locally