feat: Rename project new/rm to start/stop, add restart + other args fixes
#771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesedo
reviewed
Mar 31, 2023
| @@ -68,7 +68,13 @@ impl Shuttle { | |||
| Command::Deploy(..) | |||
| | Command::Deployment(..) | |||
| | Command::Resource(..) | |||
| | Command::Project(..) | |||
| | Command::Project( | |||
| // ProjectCommand::List does not need to know which project we are in | |||
| @@ -366,7 +375,7 @@ impl Shuttle { | |||
| if let Some(deployment) = summary.deployment { | |||
| deployment.id | |||
| } else { | |||
| return Err(anyhow!("could not automatically find a running deployment for '{}'. Try passing a deployment ID manually", self.ctx.project_name())); | |||
| bail!("Could not automatically find a running deployment for '{}'. Try passing a deployment ID manually", self.ctx.project_name()); | |||
There was a problem hiding this comment.
I can't quite remember, but doesn't return Err(...) make the format of the error better by catching the Err somewhere?
There was a problem hiding this comment.
From https://docs.rs/anyhow/latest/anyhow/macro.bail.html
This macro is equivalent to
return Err(anyhow!($args...)).
I'd be surprised if that actually affected formatting 🧐
chesedo
approved these changes
Mar 31, 2023
oddgrd
approved these changes
Apr 3, 2023
|
shuttle-hq/shuttle-docs#62 @oddgrd Ready to merge |
|
Terrific, thanks @jonaro00! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
new/rmtostart/stop: Why? The "rm" implies that something is deleted, which confuses some. Other suggestions for names are accepted. "create/destroy" instead? recreate doesn't sound as good as restart :/cargo shuttle project restart(stop+start), since this is and has been a very commonly recommended operation (We will save so many keystrokes in Discord 🤠)cargo shuttle project listbe run whether in a Cargo project or notHow Has This Been Tested (if applicable)?
Tested against production. The restart command works as expected from both running and stopped states.