feat examples: switch to relative url for examples submodule to allow… #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge up to see if that fixes the deployer test failure. |
chesedo
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Thanks for this @jhawkesworth!!
We'll fix the tests in the next few days - they are not related to your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… git cloning via git or https
Description of change
I use PAT token to access github, rather than an ssh key.
The submodules specification is currently hardcoded to use a git:// url which means when I follow the contributing instructions,
git submodule updatefails.This PR changes the submodule referent to a relative url which allows
git submodule updateto work.There are no linked issues, but I have mentioned this in contributors channel on discord.
How Has This Been Tested (if applicable)?
Only testing I have done is locally on my machine.
I guess this PR might have the potential to break CI as I found I had to run
git submodule syncbefore the change in the PR took effect. Other developers who have existing code checked out will also need to rungit submodule syncso this ought to go in the release notes and/or contributing guide.