Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert use of portpicker for local run #787

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Apr 11, 2023

Description of change

Revert the use of portpicker to get the port to start a service on for local runs.

How Has This Been Tested (if applicable)?

Local runs.

Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Pieter <pieter@chesedo.me>
@oddgrd oddgrd merged commit 4f34b49 into shuttle-hq:main Apr 12, 2023
@oddgrd oddgrd deleted the fix/revert-use-of-portpicker-local-run branch April 12, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants