Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add cargo shuttle logs --latest #799

Merged
merged 9 commits into from
Apr 18, 2023
Merged

feat: Add cargo shuttle logs --latest #799

merged 9 commits into from
Apr 18, 2023

Conversation

jonaro00
Copy link
Member

Description of change

Closes #743
/claim #743

Adds the described functionality.

How Has This Been Tested (if applicable)?

Tested against my projects in production. Works as expected.

@algora-pbc algora-pbc bot mentioned this pull request Apr 15, 2023
Closed
1 task
oddgrd
oddgrd reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonaro00! I added a couple of comments/questions, but this looks good!

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
@jonaro00 jonaro00 requested a review from oddgrd April 17, 2023 14:41
oddgrd
oddgrd approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jonaro00! Thanks for adding a test as well. And congratulations on submitting the first approved bounty PR, very well deserved!

cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
deployer/src/persistence/mod.rs Show resolved Hide resolved
@oddgrd oddgrd merged commit 5bdd892 into shuttle-hq:main Apr 18, 2023
@jonaro00 jonaro00 deleted the feat/latest-log branch April 18, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Show latest log when no deployment is active
2 participants
@jonaro00 @oddgrd