Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: linux QA #800

Merged
merged 22 commits into from
Apr 17, 2023
Merged

ci: linux QA #800

merged 22 commits into from
Apr 17, 2023

Conversation

chesedo
Copy link
Contributor

@chesedo chesedo commented Apr 17, 2023

Description of change

This sets up a CI workflow to test our QA on Linux before a release.

How Has This Been Tested (if applicable)?

The CI will do that 😉

@chesedo chesedo force-pushed the feature/eng-588-create-linux-ci-for-qa branch from 757d28b to 737723b Compare April 17, 2023 08:03
@chesedo chesedo force-pushed the feature/eng-588-create-linux-ci-for-qa branch from 7026997 to 530d167 Compare April 17, 2023 08:22
@chesedo chesedo force-pushed the feature/eng-588-create-linux-ci-for-qa branch from 1326dc0 to 0c9bc7e Compare April 17, 2023 08:39
@chesedo chesedo force-pushed the feature/eng-588-create-linux-ci-for-qa branch from 3fa1511 to 89e8eca Compare April 17, 2023 09:20
@chesedo chesedo force-pushed the feature/eng-588-create-linux-ci-for-qa branch from 89e8eca to edb1d2e Compare April 17, 2023 09:34
@chesedo chesedo marked this pull request as ready for review April 17, 2023 12:59
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So is protoc already installed on this image then? I suppose it's not really important either way, since we can remove it this week (with a fork if we need to).

.circleci/qa-wasm.sh Outdated Show resolved Hide resolved
@chesedo
Copy link
Contributor Author

chesedo commented Apr 17, 2023

So is protoc already installed on this image then?

I just tested and protoc is installed in the ubuntu image. I'm not sure why though...

@chesedo chesedo force-pushed the feature/eng-588-create-linux-ci-for-qa branch from a643489 to efa22b2 Compare April 17, 2023 15:29
@chesedo chesedo merged commit 44c1299 into main Apr 17, 2023
@chesedo chesedo deleted the feature/eng-588-create-linux-ci-for-qa branch April 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants