Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply admin layer to admin routes only #818

Merged
merged 3 commits into from
Apr 26, 2023

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Apr 26, 2023

Description of change

The admin layer was being applied to all default routes, with this change it will be applied only to the routes in the nested admin router.

How Has This Been Tested (if applicable)?

TODO

Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oddgrd for the fix ! LGTM!

@oddgrd oddgrd merged commit f225da0 into shuttle-hq:main Apr 26, 2023
@oddgrd oddgrd deleted the fix/gateway-admin-routes branch April 26, 2023 11:37
oddgrd added a commit that referenced this pull request Apr 27, 2023
* fix: apply admin layer to admin routes only

* test: add some asserts to check admin route

* fix: clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants