feat: add --features argument to cargo shuttle run

[orhun]

Description of change

This PR adds --features argument to run subcommand for activating cargo features.

See #913 for more detail.

How Has This Been Tested (if applicable)?

I ran it locally, worked fine.

[jonaro00]

It's a good feature request.
It would be suitable to make it work for deployments as well. Not sure if this complicates things.
It's worth considering how this affects #756, but it seems completely fine.

[orhun]

It would be suitable to make it work for deployments as well. Not sure if this complicates things.

I was going to implement it for deployments as well but couldn't figure out how deploy command works. I guess the build happens somewhere else since it only sends a request along with a compressed archive, right? I would be happy to go ahead and implement it if I can get a better understanding of the internals.

It's worth considering how this affects #756, but it seems completely fine.

Oh, I think it is easily convertable to execute the cargo command instead, so I agree.

[jonaro00]

It would probably work to add them as a URL parameter, like no_test is now.

But I remembered there is another challenge:
In the PR now, all shuttle crates in the workspace gets the same feature flags set.
Specifying flags to individual crates becomes a challenge.
Related:

• similar request as the --features: [Feature]: Support for choosing binary target #751
• unresolved questions about workspace: feat: compile an entire workspace #767 (comment)

[iamwacko]

#756 has been merged now, so you will have to make some changes.

[oddgrd]

Hey @orhun, thanks for getting started on this! Apologies for the delayed review, but we're in the middle of a major refactor of how we build crates and deploy users projects. I think it makes sense to hold off on this until that is all merged. The PR for the builder should be up within a few days!

[orhun]

Refactored the code to use the new cargo build mechanism. Let me know if it looks okay!

I might provide another PR for the deploy subcommand.

[jonaro00]

There was a discussion about this the other day, regarding design of multi-service deploys.
Sadly, it looks like shuttle services will require the default binary and features to be the shuttle version of the crate.
It does not only apply to --features, so supporting customization of this sort becomes a catch up game with cargo's build and run

[orhun]

I see, in that case, what exactly is needed?

[jonaro00]

Something like this https://github.com/shuttle-hq/shuttle-examples/pull/61/files

[orhun]

Unfortunately I'm still not following. I guess I will wait a bit until things stabilize 😅

[jonaro00]

Yeah, with the major deployment rewrite coming up there are a lot of question marks from me as well.

[oddgrd]

I'll close this for now @orhun, we can pick it up again when we're implementing the builder, but it will likely take a different shape.