-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for easier updating #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jules Bouton <47297745+JPapir@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 94.30% 92.11% -2.20%
==========================================
Files 3 6 +3
Lines 246 317 +71
==========================================
+ Hits 232 292 +60
- Misses 14 25 +11 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 16, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major breaking refactor that accomplishes a few things:
Citation
andCitationBlock
to make the process of extracting various types of citations from markdown easier to test and validateRegistry
into an abstract class with a clearer interfaceSimpleRegistry
that uses Pybtex for basic citations conversionPandocRegistry
that uses Pandoc and can handle CSL stylesPandocRegistry
As part of this there are some breaking changes:
cite_inline
as this is automatically detected from the CSL file now