Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to specify reporter output that contains spaces in path #177

Closed
Tapchicoma opened this issue Mar 19, 2018 · 3 comments
Closed

Fail to specify reporter output that contains spaces in path #177

Tapchicoma opened this issue Mar 19, 2018 · 3 comments

Comments

@Tapchicoma
Copy link
Collaborator

It was requested in ktlint-gradle plugin to support reporters output path that contains spaces.

I've tried following approaches to check if it supported on Ktlint side:

$ ~/tmp/ktlint --debug --reporter=plain,output="/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt" "src/**/*.kt"
Error: "--reporter=plain,output=/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt" is not a valid option
$ ~/tmp/ktlint --debug --reporter=plain,output=/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt "src/**/*.kt"
[DEBUG] Discovered ruleset "standard"
[DEBUG] Discovered reporter "plain"
[DEBUG] Discovered reporter "json"
[DEBUG] Discovered reporter "checkstyle"
[DEBUG] Initializing "plain" reporter with {verbose=false, color=false}, output=/home/user/some
[DEBUG] Checking /home/user/some dir with spaces/samples/android-app/src/androidTest/java/org/jlleitschuh/gradle/ktlint/android/ExampleInstrumentedTest.kt
[DEBUG] Checking /home/user/some dir with spaces/samples/android-app/src/main/java/org/jlleitschuh/gradle/ktlint/android/ItemDetailActivity.kt
[DEBUG] Checking /home/user/some dir with spaces/samples/android-app/src/main/java/org/jlleitschuh/gradle/ktlint/android/ItemDetailFragment.kt
[DEBUG] Checking /home/user/some dir with spaces/samples/android-app/src/main/java/org/jlleitschuh/gradle/ktlint/android/ItemListActivity.kt
[DEBUG] Checking /home/user/some dir with spaces/samples/android-app/src/main/java/org/jlleitschuh/gradle/ktlint/android/dummy/DummyContent.kt
[DEBUG] Checking /home/user/some dir with spaces/samples/android-app/src/test/java/org/jlleitschuh/gradle/ktlint/android/ExampleUnitTest.kt
[DEBUG] 983ms / 6 file(s) / 0 error(s)
$  ~/tmp/ktlint --reporter=plain,output=/home/user/some\ dir\ with\ spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt "src/**/*.kt"         
Error: "--reporter=plain,output=/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt" is not a valid option
@eskatos
Copy link

eskatos commented Mar 20, 2018

This should work:

$ ~/tmp/ktlint "--reporter=plain,output=/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt" "src/**/*.kt" 

that is, quoting the whole "--reporter=..." argument.

@Tapchicoma
Copy link
Collaborator Author

Hm, I also getting error in this case as well:

$ ~/tmp/ktlint --debug "--reporter=plain,output=/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt" "src/**/*.kt"
Error: "--reporter=plain,output=/home/user/some dir with spaces/samples/android-app/build/reports/ktlint/ktlint-debugAndroidTest.txt" is not a valid option

@shyiko shyiko closed this as completed in f383257 Mar 21, 2018
@shyiko
Copy link
Collaborator

shyiko commented Mar 21, 2018

Fixed in 0.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants