Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventType comment. #35

Merged
merged 4 commits into from
Apr 3, 2015
Merged

Fix EventType comment. #35

merged 4 commits into from
Apr 3, 2015

Conversation

chenyun
Copy link
Contributor

@chenyun chenyun commented Mar 31, 2015

No description provided.

@shyiko
Copy link
Owner

shyiko commented Apr 2, 2015

Fixed EventHeaderV4Deserializer eventLength handling is definitely "must merge". Thank you. Query event description on the other hand... I'd rather stick with the current one because there are some special-meaning queries like BEGIN/COMMIT which are not really updating anything on their own.
Would you care to open a separate PR for "fix EventHeaderV4Deserializer type bug"?

@chenyun
Copy link
Contributor Author

chenyun commented Apr 3, 2015

Hi @shyiko ,
the QueryEvent comment I used is the same as MySQL document.
For "Represent query statement", I think it's ambiguous.
While "Written when an updating statement is done" means it's the first event of an updating statement.

Query :  Begin   
RowsQuery:   insert/update/delete sql  
TableMap :   
Rows :  Write/Update/DELETE  
Query/XId

Refer: https://dev.mysql.com/doc/internals/en/event-meanings.html

@shyiko
Copy link
Owner

shyiko commented Apr 3, 2015

Fair enough. Merging in.

shyiko added a commit that referenced this pull request Apr 3, 2015
Updated EventType.QUERY description / Fixed EventHeaderV4.eventLength deserialization
@shyiko shyiko merged commit f1fb18b into shyiko:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants