Allow Github style merge commits in no repeated commits rule #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benedikt-Brunner
force-pushed
the
allow-github-merge-commits-in-repeated-commits-rule
branch
from
08d310e
to
93b7360
Compare
shyim
approved these changes
Jun 24, 2024
|
Thank you! |
Benedikt-Brunner
deleted the
allow-github-merge-commits-in-repeated-commits-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a filter for Github style merge commits to the repeated commits rule. As it is a feature of the platform which by its automated nature will lead to repeated commit names, it's sensible to filter them out by default (the goal of making the programmer clearly state his intent with every real commit is still achieved).
There are several different approaches one could take to implementing this feature, including adding a dynamic filter based on the current platform or making the filter step configurable. However since i am new to the project and just wanted to get general feedback on the idea i decided on building the most simple version for now. If any of the more complex versions are desired i would also be happy to implement them.