fix interface bug for db health checks

sia-digital · Nov 25, 2024 · a9d7708 · a9d7708
1 parent b63c2a0
commit a9d7708
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/...ce/EntityFramework/src/PiBox.Plugins.Persistence.EntityFramework/EntityFrameworkPlugin.cs b/...ce/EntityFramework/src/PiBox.Plugins.Persistence.EntityFramework/EntityFrameworkPlugin.cs
@@ -38,7 +38,7 @@ public void ConfigureApplication(IApplicationBuilder applicationBuilder)
         public void ConfigureHealthChecks(IHealthChecksBuilder healthChecksBuilder)
         {
             var dbContexts = implementationResolver.FindAssemblies().SelectMany(x => x.GetTypes())
-                .Where(x => x.GetInterfaces().Any(i => i == typeof(IDbContext)))
+                .Where(x => x.IsClass && !x.IsAbstract && x.IsAssignableTo(typeof(IDbContext)))
                 .ToList();
             var registerHc = typeof(DependencyInjectionExtensions).GetMethods(BindingFlags.Static | BindingFlags.Public)
                 .Single(x => x.GetParameters().Length == 1 && x.GetParameters()[0].ParameterType == typeof(IHealthChecksBuilder));

diff --git a/...mework/test/PiBox.Plugins.Persistence.EntityFramework.Tests/EntityFrameworkPluginTests.cs b/...mework/test/PiBox.Plugins.Persistence.EntityFramework.Tests/EntityFrameworkPluginTests.cs
@@ -67,6 +67,7 @@ public void ConfiguresHealthChecks()
             _implementationResolver.FindAssemblies().Returns([typeof(EntityFrameworkPluginTests).Assembly]);
             var healthCheckBuilder = Substitute.For<IHealthChecksBuilder>();
             _plugin.ConfigureHealthChecks(healthCheckBuilder);
+            healthCheckBuilder.Received(1).Add(Arg.Any<HealthCheckRegistration>());
             healthCheckBuilder.Received(1).Add(Arg.Is<HealthCheckRegistration>(h => h.Name == nameof(TestContext)));
         }