-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust S3 Plugin for HealthCheck Configuration #61
Adjust S3 Plugin for HealthCheck Configuration #61
Conversation
use github pull request target to be able to run build
@apurkovic @tst-sia can anyone from you review this pull request? |
Hello @lukas-kd, we reviewed the changes and ran into problems with the Kafka.Flow.Tests project (with regards to Google.Protobuf, protobuf-net packages) aswell as the OpenApiPlugin Tests on our local machines under Windows 10. We managed to fix some of them and assume we've found part of the culprit for others but we would for now suggest you open a new PR with just the S3 changes you need and no nuget updates (as we would rather separate those right now). |
@tst-sia i've reverted the package raises. Do you have any plans for upgrading the nuget packages? Some of them contains vulnerabilities. Thanks in advance. |
@lukas-kd Thank you, we'll look at upgrading the packages within this or next week. I've approved the S3 changes and merged them. |
This pull request introduces enhancements to the S3 plugin by adding configuration options for health checks. Specifically:
HealthCheckPath
property to the configuration, allowing more control over the health check process.HealthCheckPath
) or fall back to checking only the base domain.These changes provide increased flexibility in monitoring and ensure that the health check can be tailored to specific URLs or general availability of the domain.
Changes Summary:
HealthCheckPath
property to the S3 plugin configuration.HealthCheckPath
) or just the base domain, based on configuration.Testing:
HealthCheckPath
URL.Motivation:
This change allows more specific monitoring of S3 instances, improving reliability and reducing false positives when checking the service's health.
Please review and let me know if further adjustments are needed.