-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package pipeline #17
Conversation
Thanks for the PR. Will check this weekend. Also, it would be really helpful for everyone to get this changes to svelte kit itself. |
Hi, thanks for the PR @DougAnderson444 . The changes looks good. But would you be able to provide a minimal reproduction of the bug? I haven't faced the issue myself, it would help me get a clear picture of it so maintaining these changes would be easy for me in future. |
ping @DougAnderson444 |
It's a bit of an edge case honestly, I was trying to import this library in a fork of the Svelte REPL, and it was giving me a headache. The fact that your code works on the official REPL probably means I need an update elsewhere or have a bug |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread. |
This PR address sveltejs/kit#16 to ensure
.js
extensions are used when packaging for npm. File extensions are required for Node.js compatibility across the board, and currently when svelte-tiptap is packaged the typescript (lack of) extensions don't get converted to.js
extensions.This PR fixes that.
The workaround for sveltejs/cli#205 with
ts-patch
andtypescript-transform-extensions
and is used until kit publishes an official fix.The latest
@sveltejs/package
is used where it is saved todist
folder, so there is anpublish:npm
script command also added to thepackage.json
so it's clear that the root folder should be published (instead of the legacy./package
folder).