Tab close does not close the tab directly anymore. The server removes…

… the tab, and sends the remove to the client.
sibvisions · Sep 27, 2024 · e58f56a · e58f56a
1 parent 31c3deb
commit e58f56a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/main/components/panels/tabsetpanel/TabsetPanelImpl.tsx b/src/main/components/panels/tabsetpanel/TabsetPanelImpl.tsx
@@ -189,7 +189,7 @@ const TabsetPanelImpl: FC<ITabsetImpl & IComponentConstants> = (props) => {
                     style={{"--nav-background": props.compStyle.background} as CSSProperties}
                     activeIndex={props.selectedIndex}
                     onTabChange={event => props.onTabChange(event.index)}
-                    onTabClose={event => props.onTabClose(event.index)}
+                    onBeforeTabClose={event => props.onTabClose(event.index)}
                     {...usePopupMenu(props)}>
                     {builtTabs}
                 </TabView>

diff --git a/src/main/components/panels/tabsetpanel/UITabsetPanel.tsx b/src/main/components/panels/tabsetpanel/UITabsetPanel.tsx
@@ -78,7 +78,9 @@ const UITabsetPanel: FC<ITabsetPanel & IExtendableTabsetPanel & IComponentConsta
         }
 
         showTopBar(props.context.server.sendRequest(buildTabRequest(tabId), REQUEST_KEYWORDS.CLOSE_TAB), props.topbar);
-        closing.current = true
+        closing.current = true;
+
+        return false;
     }
 
     return (