Accept opencv alternatives #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreSi
reviewed
Jul 15, 2020
Co-authored-by: AlexandreS <32449369+AlexandreSi@users.noreply.github.com>
RaphaelMeudec
approved these changes
Jul 24, 2020
|
@boussoffara LGTM! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix to #142 : remove tensorflow and opencv dependency from setuptools but check for a valid version at import time and raise a helpful error:
"TF-explain requires Opencv. Install Opencv via
pip install opencv-python""TF-explain requires TensorFlow 2.0 or higher. Install TensorFlow via
pip install tensorflow"Assuming most users would have a flavor of both installed this would avoid installing conflicting packages.
For beginners the error should quickly guide them to the fix