-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Windows Installation section #422
Conversation
Fix typos, more professional language, fix incorrect information.
Thanks so much for this @kimjammer! Here's the draft where I was and the reason why I didn't merge it for so long, do you see anything here worth adding? ### I'd like to run Docker-OSX on Windows Running Docker-OSX on Windows is now possible using WSL2 (Windows 10/11 + WSL Subsystem). Windows 10: Build 20175 or higher. Windows 11: Supported by default. Next, ensure you have enabled the features on your Windows. Search using the Start Menu for "Turn Windows Features on or off" and enable these checkbox; enable the following Windows Features:
Once enabled, your PC will ask to restart. You can confirm WSL2 is enabled using In PowerShell you can see available distributions to install: If you only have WSL1 (WSL) but not WSL2, you will need to upgrade to WSL version 2: see here how to upgrade from WSL1 to WSL2 in case you have already installed WSL Distro. After WSL2 has been installed, go to In File Explorer, you will need to The result should be like this:
Open PowerShell as Administrator and enter Open your WSL Distro (e.g Ubuntu) via the Start Menu and check if KVM is enabled by using
It's time to download and install Docker for Windows. After installation, go to Setting and check these 2 checkbox:
Ensure From now, you have 3 way to get video output:
|
Fix typo in command to check available wsl linux distros.
I've read over your comment. Here are the major differences in my version.
|
Everything else looks wonderful, and most of that information is now in my patch! |
+ Makes it easier to read and matches the rest of the README. |
instead of this: After WSL2 has been installed, go to C:\Users<Your_Name>.wslconfig and add nestedVirtualization=true to the end of a file named .wslconfig (If the file not exist, create it). In File Explorer, you will need to Show Hidden Files and Show File Extensions. Edit like this: After WSL2 has been installed, go to C:\Users<Your_Name>.wslconfig and add nestedVirtualization=true to the end of a file named .wslconfig (If the file not exist, create it). You have to check if the file exist and hidden but most of the time the file not exist. @kimjammer You have to check if the wsl and hyper-v is enabled so you have to check the procedure in the windows features. |
Ok, I'll change the order of those instructions. With all due respect, I'm assuming you live in a non-English speaking part of the world? Your English seems to be a bit less than professional. For the second point, installing WSL only requires that command now. See this part of the docs. The command automatically enables the required windows features. I installed WSL on a brand new install of Windows a couple days ago, and that command took care of everything. |
@MikeCoder96 Also, are you sure you looked at the correct part of the PR? The text you quoted is from sickcode's comment, not my changes. |
[@kimjammer](https://github.com/kimjammer) Update Windows Installation section #422 [@mhartig](https://github.com/Mhartig) - Worked out issue `Enter a number (default=1): error: invalid number: y` [@felipestt](https://github.com/felipestt) Use more CPU Cores/SMP' broken #440 [@routmoute](https://github.com/routmoute) README: add PulseAudio with WSLg #442 [@dulatello08](https://github.com/dulatello08) Update README.md #452
Fix typos, more professional language, fix incorrect information.
Using new WSL installation method that uses powershell and not windows features.
Add missing information about .wslconfig.
Re-add info about using WSLg that was removed.