Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc improvements to build, runtime and documentation #82

Merged
merged 9 commits into from
Sep 24, 2020
Merged

misc improvements to build, runtime and documentation #82

merged 9 commits into from
Sep 24, 2020

Conversation

jimdigriz
Copy link
Contributor

@jimdigriz jimdigriz commented Sep 20, 2020

Several proposed improvements:

  • remove the need for privileged
  • reduce final image by ~2.5GB (from 6GB)
  • support fallback from kvm to tcg
  • use shell expansions and push DISPLAY into ENV so it does not need to be supplied
  • provide example on how to use PulseAudio

@jimdigriz jimdigriz changed the title Tweaks misc improvements to build, runtime and documentation Sep 20, 2020
@sickcodes
Copy link
Owner

This looks awesome, I will go thru it tomorrow :) thanks for working on this

@sickcodes
Copy link
Owner

I originally had the shell expansions on RAM CORES etc., only issue I could foresee was people would have to dig to see it.

Excited to build your image tomorrow 😁

@jimdigriz jimdigriz closed this Sep 20, 2020
@jimdigriz jimdigriz reopened this Sep 20, 2020
@jimdigriz
Copy link
Contributor Author

I originally had the shell expansions on RAM CORES etc., only issue I could foresee was people would have to dig to see it.

It's all proposals and just the collection of notes I have myself when using Docker-OSX. Use what you can and find useful!

@sickcodes
Copy link
Owner

Definitely will!

Running in non privileged has always been a goal, I was unaware how to achieve that, thanks for submitting this

@sickcodes sickcodes merged commit 07f488a into sickcodes:master Sep 24, 2020
@sickcodes
Copy link
Owner

@jimdigriz Dude this PR is awesome, taught me some new stuff :)

Tested, worked like a charm.

Has a cool verbose boot now too, might be upstream tho.

Thanks again!

@jimdigriz
Copy link
Contributor Author

Really pleased you found it useful and worth reviewing and accepting.

Thank you for putting this together so lazy people (like me!) can quickly get a local macOS instance.

@banderlog banderlog mentioned this pull request May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly simpler invocation
2 participants