Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to nitro 2.10, preparing for nitropack ecosystem switch from nitropack to nitro #942

Merged
merged 8 commits into from
Dec 12, 2024

Conversation

BracketJohn
Copy link
Contributor

@BracketJohn BracketJohn commented Nov 12, 2024

πŸ”— Linked issue

N/A

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR upgrades nitropack@2.9.7 to nitropack@2.10.4. This resolves two issues:

  • existing: nitropack@2.9.7 relies on an unimport-version that augments the vue-runtime-core types, which was deprecated with vue 3.5: fix: drop declare module '@vue/runtime-core'Β unjs/unimport#359
  • upcoming: nitropack@2.10.4 changes the package structure for an upcoming switch to the new name nitro with the release of v3. So if people upgrade to latest nuxt and in turn also upgrade all sub-deps to latest nitro, the import that nuxt-auth has from nitropack will break (see changes I made here)

See https://github.com/nitrojs/nitro/releases/tag/v2.10.0 for more on the namespace change.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@sidebase/nuxt-auth@942

commit: 634295e

@BracketJohn
Copy link
Contributor Author

@phoenix-ru / @zoey-kaiser: Opening this to raise awareness of the above potential issues. Feel free to merge as is / close / put into another dep-upgrade PR.

zoey-kaiser
zoey-kaiser previously approved these changes Nov 12, 2024
Copy link
Collaborator

@phoenix-ru phoenix-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple duplicate packages in the lockfile (majority wasn't duplicated prior to this PR)

At the very least it will cause undefined behaviour when developing nuxt-auth.

@BracketJohn which command did you use to update nitropack? I think a deduplication run needs to happen on the lockfile

pnpm-lock.yaml Show resolved Hide resolved
pnpm-lock.yaml Show resolved Hide resolved
pnpm-lock.yaml Show resolved Hide resolved
@phoenix-ru phoenix-ru merged commit dd77b70 into main Dec 12, 2024
7 checks passed
@phoenix-ru phoenix-ru deleted the upgrade_nitro_to_2.10 branch December 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants