-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to nitro 2.10, preparing for nitropack ecosystem switch from nitropack
to nitro
#942
Conversation
β¦h from nitropack to nitro
commit: |
@phoenix-ru / @zoey-kaiser: Opening this to raise awareness of the above potential issues. Feel free to merge as is / close / put into another dep-upgrade PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are multiple duplicate packages in the lockfile (majority wasn't duplicated prior to this PR)
At the very least it will cause undefined behaviour when developing nuxt-auth
.
@BracketJohn which command did you use to update nitropack
? I think a deduplication run needs to happen on the lockfile
π Linked issue
N/A
β Type of change
π Description
This PR upgrades
nitropack@2.9.7
tonitropack@2.10.4
. This resolves two issues:nitropack@2.9.7
relies on an unimport-version that augments the vue-runtime-core types, which was deprecated with vue 3.5: fix: dropdeclare module '@vue/runtime-core'
Β unjs/unimport#359nitropack@2.10.4
changes the package structure for an upcoming switch to the new namenitro
with the release ofv3
. So if people upgrade to latest nuxt and in turn also upgrade all sub-deps to latest nitro, the import thatnuxt-auth
has fromnitropack
will break (see changes I made here)See https://github.com/nitrojs/nitro/releases/tag/v2.10.0 for more on the namespace change.
π Checklist