-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update installation.md #955
Conversation
β¦ as regular dep @sidebase/nuxt-auth should be installed as a regular dependency instead of a dev dependency. Also added additional scripts for yarn and pnpm
This should not be the case. Any Nuxt module can be installed as a Dev Dependency. NextAuth needs to be installed as a regular dependency. Did you have issues installing it as a dev dependency? If so could you please share some more information on this please? π |
npm i @sidebase/nuxt-auth | ||
``` | ||
|
||
```bash [pnpm] | ||
pnpm i -D @sidebase/nuxt-auth | ||
pnpm i @sidebase/nuxt-auth | ||
``` | ||
|
||
```bash [yarn] | ||
yarn add --dev @sidebase/nuxt-auth | ||
yarn add @sidebase/nuxt-auth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert to the dev dependency so we can accept your other adjustment :)
Additionally - does the nuxi module add
command work for you? There's #932 which reported it not functioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted to dev dep. The nuxi module add sidebase-auth
command works fine, although it installed an RC Version of @sidebase/nuxt-auth
for me. I could submit an PR regarding that. It also installs it as a regular dependency, and it installs next-auth
too. Which is not mentioned in the docs. Do we want to include it in the docs too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rc
installation was a small hiccup from our side which we fixed today, it should no longer be installed as latest
, thanks for noticing it as well!
next-auth
is a peer dep, it would very much depend on your package manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use pnpm, and it did not install next-auth
and I ran into some issues. Don't you think that it should be included in the docs anyway?
commit: |
Thanks for the PR :) |
β¦ as regular dep@sidebase/nuxt-auth should be installed as a regular dependency instead of a dev dependency.Also added additional scripts for yarn and pnpmπ Linked issue
β Type of change
π Description
Also added pnpm and yarn script variants of@sidebase/nuxt-auth
should be installed as a regular dependecy instead of dev dependency.npx nuxi@latest module add sidebase-auth
π Checklist