fix: multiple data race issues #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See siderolabs/talos#9466 There were multiple issues: * a pointer to a slice element might point to a different element if the slice contents change (chunks are recycled) * compression buffer can't be reused, as it might be still used in the reader doing decompression * incorrect handling of growing initial buffer in streaming reads Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
dsseng
approved these changes
Oct 15, 2024
frezbo
approved these changes
Oct 15, 2024
Unix4ever
approved these changes
Oct 15, 2024
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 16, 2024
Fixes siderolabs#9466 There are two fixes: * fix the actual panic via siderolabs/go-circular#5 * prevent similar issues in the future by installing a panic handler Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 16, 2024
Fixes siderolabs#9466 There are two fixes: * fix the actual panic via siderolabs/go-circular#5 * prevent similar issues in the future by installing a panic handler Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Oct 25, 2024
Fixes siderolabs#9466 There are two fixes: * fix the actual panic via siderolabs/go-circular#5 * prevent similar issues in the future by installing a panic handler Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 5853bb0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See siderolabs/talos#9466
There were multiple issues: