feat: stop decoding without error if EOF encountered during header read #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
fix/dmi-header-eof
branch
from
00fd35a
to
f8ef0db
Compare
Linux v6.6.39 stops decoding with EOF in this situation but maintains the already decoded structures. See /drivers/firmware/dmi_scan.c Fixes siderolabs#16 Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/dmi-header-eof
branch
from
f8ef0db
to
e781237
Compare
|
I updated the code, brought back removed tests, and made it actually match Linux - to assume table done on any header short read. |
frezbo
approved these changes
Aug 23, 2024
smira
approved these changes
Aug 23, 2024
|
/m |
|
Ok, yeah I returned an empty header and relied on the existing behavior with zero value Header but probably better indeed to treat both "bad DMI" cases individually. Thanks! |
The problem was with Thank you for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux v6.6.39 stops decoding with EOF in this situation but maintains the already decoded structures. See /drivers/firmware/dmi_scan.c
I included a test with the DMI I'm using.
Fixes #16