chore: add side-by-side tests with official proto.Marshal and Unmarshal #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauterp
approved these changes
Jul 26, 2022
smira
reviewed
Jul 26, 2022
DmitriyMV
force-pushed
the
side-by-side
branch
4 times, most recently
from
a4f1b51
to
4c842c8
Compare
This test ensures that our encoding is compatible with official proto modules. It doesn't verify that binary form is equivalent because we do encode zero values, unlike official encoder. Also add simple fuzzing. Closes #2 Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests ensures that our encoding is compatible with official proto modules.
Closes #2
Signed-off-by: Dmitriy Matrenichev dmitry.matrenichev@siderolabs.com