Fix RPC input error handling #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkerj
force-pushed
the
master
branch
2 times, most recently
from
93ff5b6 to
018540c
Compare
It really helps finding out what's going wrong when vsphere and talos-vmtoolsd are not happy with each other. Also, log request as string instead of []byte, so logrus does not base64 it. Signed-off-by: Jorik Jonker <jorik.jonker@eu.equinix.com>
open-vm-toolsd seems to prefix error replies with "ERROR " instead of "ERR " (when there is a callback) of "" (when there is no callback). Signed-off-by: Jorik Jonker <jorik.jonker@eu.equinix.com>
Remove hardcoded references to main repo, remove dependency on repo secrets. Signed-off-by: Jorik Jonker <jorik.jonker@eu.equinix.com>
|
Thank you, again, and sorry for taking so long to get back to you with this! It is interesting that vSphere did not process guestinfo commands anymore after the invalid response, since I do not observe this behavior with an identical basic stack on my end (vSphere 7 U0-U2 enterprise + vSAN). Wondering what component is sending those. The error you fixed interestingly exists in the original govmomi service implementation too and remained undetected there, but I checked against open-vm-tools and prefixing with ERROR instead of ERR or nothing is correct behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our environment (vSphere 7.0, ESXi 7.0) we got a lot of errors about
Unable to send a message over the communication channel 0and vSphere did not process any guest info being submitted. In order to debug this, we improved the logging of the tool, the GitHub workflow to actually build images in our fork and ultimately the way error responses were sent.We suspect vSphere/ESXi are sending "unknown" RPC requests, which got responded in an invalid way ("Unknown Command" instead of "ERROR Unknown Command"). We've digged into the way
open-vm-toolsdhandle unknown RPC requests and mimiced these.The tool now works perfectly on our environment.