chore(ci): fix parallel runs of tf pipelines

Previously it was generating same name for the state file causing parallel runs to delete resources created by another running test. Fix names to be unique by reading `cluster_name`. Signed-off-by: Noel Georgi <git@frezbo.dev>
siderolabs · Jul 3, 2024 · 9a56b85 · 9a56b85
1 parent be35f38
commit 9a56b85
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/hack/test/e2e-cloud-tf.sh b/hack/test/e2e-cloud-tf.sh
@@ -2,52 +2,49 @@
 
 set -eou pipefail
 
-source ./hack/test/e2e.sh
-
 # This script is used to run the end-to-end tests on a cloud provider using Terraform.
 
-if [[ "${CI}" != "true" ]]; then
-    echo "This script is only meant to be run in CI."
-    exit 1
-fi
-
 BUCKET_NAME="talos-ci-e2e"
+TF_DIR="${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}"
+
+cp "${TF_SCRIPT_DIR}/hack/backend-aws.tf" "${TF_DIR}/backend.tf"
 
-cp "${TF_SCRIPT_DIR}/hack/backend-aws.tf" "${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}/backend.tf"
+cp "${ARTIFACTS}/e2e-${TF_E2E_TEST_TYPE}-generated"/* "${TF_DIR}"
 
-cp "${ARTIFACTS}/e2e-${TF_E2E_TEST_TYPE}-generated"/* "${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}"
+CLUSTER_NAME=$(jq -e -r '.cluster_name' "${TF_DIR}/vars.json")
+BACKEND_CONFIG_KEY="cloud-tf/${CLUSTER_NAME}-terraform.tfstate"
 
-terraform -chdir="${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}" \
+terraform -chdir="${TF_DIR}" \
     init \
     -backend-config="bucket=${BUCKET_NAME}" \
-    -backend-config="key=cloud-tf/${TF_E2E_TEST_TYPE}-${GITHUB_SHA}-${GITHUB_RUN_NUMBER}-terraform.tfstate"
+    -backend-config="key=${BACKEND_CONFIG_KEY}"
 
 case "${TF_E2E_ACTION}" in
     "apply")
-        terraform -chdir="${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}" \
+        terraform -chdir="${TF_DIR}" \
             apply \
             -auto-approve \
             -var-file="vars.json"
 
-        terraform -chdir="${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}" \
+        terraform -chdir="${TF_DIR}" \
             output \
             -raw \
             talosconfig > "${ARTIFACTS}/e2e-${TF_E2E_TEST_TYPE}-talosconfig"
 
-        terraform -chdir="${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}" \
+        terraform -chdir="${TF_DIR}" \
             output \
             -raw \
             kubeconfig > "${ARTIFACTS}/e2e-${TF_E2E_TEST_TYPE}-kubeconfig"
         ;;
     "destroy")
-        terraform -chdir="${TF_SCRIPT_DIR}/examples/terraform/${TF_E2E_TEST_TYPE}" \
+        terraform -chdir="${TF_DIR}" \
             apply \
             -destroy \
             -auto-approve \
             -var-file="vars.json" \
             -refresh="${TF_E2E_REFRESH_ON_DESTROY:-true}"
 
-        aws s3api delete-object --bucket "${BUCKET_NAME}" --key "cloud-tf/${TF_E2E_TEST_TYPE}-${GITHUB_SHA}-terraform.tfstate"
+        aws s3api delete-object --bucket "${BUCKET_NAME}" --key "${BACKEND_CONFIG_KEY}"
         ;;
     *)
         echo "Unsupported action: ${TF_E2E_ACTION}"