-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for API deprecation/removal #4576
Milestone
Comments
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 23, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 23, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 29, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 29, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 29, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 29, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 29, 2021
Closes siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 30, 2021
Closes siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 30, 2021
Refs siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 30, 2021
Closes siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
AlekSi
added a commit
to AlekSi/talos
that referenced
this issue
Nov 30, 2021
Closes siderolabs#4576. Signed-off-by: Alexey Palazhchenko <alexey.palazhchenko@talos-systems.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Talos is not 1.0 yet, so technically, we can break our APIs in incompatible ways anytime. In practice, we are not doing that because that would make everyone's life harder. Still, we want to clean up our APIs before the 1.0 release: use common field names and conventions, rework APIs that are hard to use correctly, etc.
The existing
prototool break
check is a part of the solution, but not all of it.I propose to modify an existing apid_test (and maybe find a better place for it) to check
deprecated
options and comments in .proto files and fail if a deprecated entity is not removed on time.For example:
The test will fail if the current version is 0.16.
The text was updated successfully, but these errors were encountered: