Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI image cleanup might be too aggressive #8069

Closed
Tracked by #8010
smira opened this issue Dec 14, 2023 · 0 comments · Fixed by #8225
Closed
Tracked by #8010

CRI image cleanup might be too aggressive #8069

smira opened this issue Dec 14, 2023 · 0 comments · Fixed by #8225
Assignees
@smira

Comments

@smira
Copy link
Member

smira commented Dec 14, 2023 •
edited
Loading

The cleanup runs every 15 mins, removing any image in the CRI Talos namespace which is not referenced and the age is > 4*15 mins (1 hours). As the image age is the time it got pulled for the first time, the image which was referenced just a few moments ago might be cleaned up immediately, leading to blocked ability to do quick rollback of the image (e.g. kubelet image).
@smira smira mentioned this issue Dec 14, 2023
Closed
@smira smira self-assigned this Jan 31, 2024
smira added a commit to smira/talos that referenced this issue Jan 31, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
ed20307 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Jan 31, 2024
Merged
smira added a commit to smira/talos that referenced this issue Feb 1, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
4ee62df 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
smira added a commit to smira/talos that referenced this issue Feb 1, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
00b34b2 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
smira added a commit to smira/talos that referenced this issue Feb 2, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
e1f36d7 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
smira added a commit to smira/talos that referenced this issue Feb 2, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
9d20c17 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
smira added a commit to smira/talos that referenced this issue Feb 2, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
0153b7f 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
smira added a commit to smira/talos that referenced this issue Feb 2, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
ed90099 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
smira added a commit to smira/talos that referenced this issue Feb 2, 2024
@smira
fix: take into account the moment seen when cleaning up CRI images
e7475d8 
Fixes siderolabs#8069

The image age from the CRI is the moment the image was pulled, so if it
was pulled long time ago, the previous version would nuke the image as
soon as it is unreferenced. The new version would allow the image to
stay for the full grace period in case the rollback is requested.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 17567f1)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: take into account the moment seen when cleaning up CRI images smira/talos
1 participant
@smira